feat: added background to create-avd #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test lint fix added test step rewrote test to be more clear test test test test test test test test test test test test test test test fix removed eval removed old install step
FelicianoTech
previously approved these changes
Feb 17, 2023
|
I should note that the fastlane test fix simply changes the command that fastlane runs, so it prevents the orb tests from failing. Long term I need to decide whether to fix the true automation of the deployments on the sample app and add a test for that. |
JalexChen
reviewed
Feb 17, 2023
JalexChen
approved these changes
Feb 21, 2023
Thank you for implementing this so quickly. How can run the create-avd command in the background? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to run create-avd in background, moved all run steps of
create-avd.ymlinto thecreate-avd.shfile, and fixed the test-fastlane step of thetest-deployconfig. This should close #63